diff --git a/src/postorius/auth/decorators.py b/src/postorius/auth/decorators.py index bf50b43..db00069 100644 --- a/src/postorius/auth/decorators.py +++ b/src/postorius/auth/decorators.py @@ -63,7 +63,7 @@ return wrapper -def superuser_or_403(fn): +def superuser_required(fn): """Make sure that the logged in user is a superuser or otherwise raise PermissionDenied. Assumes the request object to be the first arg.""" diff --git a/src/postorius/tests/test_auth_decorators.py b/src/postorius/tests/test_auth_decorators.py index 44a3ff3..030de1b 100644 --- a/src/postorius/tests/test_auth_decorators.py +++ b/src/postorius/tests/test_auth_decorators.py @@ -23,7 +23,7 @@ from postorius.auth.decorators import (list_owner_required, list_moderator_required, - superuser_or_403) + superuser_required) from postorius.tests.utils import create_mock_list from mailmanclient import Client @@ -38,8 +38,8 @@ return True -@superuser_or_403 -def dummy_superuser_or_403(request): +@superuser_required +def dummy_superuser_required(request): return True @@ -189,7 +189,7 @@ class TestSuperUserOr403(TestCase): - """Tests superuser_or_403 auth decorator""" + """Tests superuser_required auth decorator""" def setUp(self): self.request_factory = RequestFactory() @@ -208,7 +208,7 @@ request = self.request_factory.get( '/lists/foolist.example.org/settings/') request.user = AnonymousUser() - self.assertRaises(PermissionDenied, dummy_superuser_or_403, request) + self.assertRaises(PermissionDenied, dummy_superuser_required, request) @patch.object(Client, 'get_list') def test_normal_user(self, mock_get_list): @@ -219,7 +219,7 @@ '/lists/foolist.example.org/settings/') request.user = User.objects.create_user( 'new user', 'new@usersfactory.net', 'testing') - self.assertRaises(PermissionDenied, dummy_superuser_or_403, request) + self.assertRaises(PermissionDenied, dummy_superuser_required, request) @patch.object(Client, 'get_list') def test_super_user(self, mock_get_list): @@ -230,4 +230,4 @@ '/lists/foolist.example.org/settings/') request.user = User.objects.create_superuser( 'new su', 'new@su.net', 'testing') - self.assertTrue(dummy_superuser_or_403(request)) + self.assertTrue(dummy_superuser_required(request))